Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#59765] disable hierarchy cfs from custom actions #17289

Merged
merged 2 commits into from
Nov 28, 2024
Merged

[#59765] disable hierarchy cfs from custom actions #17289

merged 2 commits into from
Nov 28, 2024

Conversation

Kharonus
Copy link
Member

@Kharonus Kharonus commented Nov 27, 2024 •
edited
Loading

Ticket

OP#59354

What are you trying to accomplish?

  • custom actions should not break

What approach did you choose and why?

  • exclude custom fields of type hierarchy from being listed as available custom actions
  • this disables setting custom fields of type hierarchy as a custom action, as all the options have to be preloaded. This can make the form very slow for big hierarchies.

@Kharonus
[#59765] disable hierarchy cfs from custom actions
05eec20 
- https://community.openproject.org/work_packages/59354
- exclude custom fields of type hierarchy from being listed as available
  custom actions
@Kharonus Kharonus requested a review from a team November 27, 2024 14:59
@Kharonus Kharonus self-assigned this Nov 27, 2024
brunopagno
brunopagno approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@brunopagno brunopagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code change make sense to me

@Kharonus
[#59765] added scope for custom fields
fc165bf 
- return those that are usable as custom actions action
@Kharonus Kharonus marked this pull request as ready for review November 28, 2024 13:09
@Kharonus Kharonus changed the base branch from dev to release/15.1 November 28, 2024 13:10
@Kharonus
Copy link
Member Author

Changed the code a bit, @brunopagno

brunopagno
brunopagno approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@brunopagno brunopagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like the use of the scope here. I wonder if the name could be better, but did not think of anything more meaningful, so I think we can go ahead.

@Kharonus Kharonus merged commit e6b4289 into release/15.1 Nov 28, 2024
11 checks passed
@Kharonus Kharonus deleted the bug/59765-custom-fields-of-type-hierarchy-are-configurable-as-searchable branch November 28, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunopagno brunopagno brunopagno approved these changes

Assignees

@Kharonus Kharonus

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kharonus @brunopagno